Variations: Ask for user confirmation before creating variations #8565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecarrion
added
the
feature: variation list
Collaborator
You can test the changes from this Pull Request by:
|
ealeksandrov
approved these changes
Jan 6, 2023
| let format = NSLocalizedString("This will create a variation for each and every possible combination of variation attributes (%d variations).", | ||
| comment: "Alert description to allow the user confirm if they want to generate all variations") | ||
| return String.localizedStringWithFormat(format, variationCount) | ||
| } |
|
|
||
| self.createVariationsRemotely(for: product, variations: variationsToGenerate, onCompletion: onCompletion) | ||
| // Confirm generation with merchant | ||
| onStateChanged(.confirmation(variationsToGenerate.count, { confirmed in |
Contributor
There was a problem hiding this comment.
This one is hard to read and understand, but I don't have easy improvement suggestions 🤔
Contributor
Author
There was a problem hiding this comment.
Yeah, not a fan either. will keep it in the back of my head for improvements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8492
Why
This PR asks the merchant for confirmation before generating multiple variations remotely.
How
Refactor
ViewModel.generateAllVariationsmethod to provide anonStateChangedclosure that will inform the consumer what is happening in the generation process.Update View controller to listen to those state changes.
Presents confirmation alert when the state change indicates.
Demo
demo.mov
Testing Step
RELEASE-NOTES.txtif necessary.